Refactored others type of subotimal asserts #7672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Han Wang <freddie.wanah@gmail.com>
7 tasks
Signed-off-by: Han Wang <freddie.wanah@gmail.com>
KumoLiu
approved these changes
Apr 23, 2024
Contributor
KumoLiu
left a comment
KumoLiu
left a comment
There was a problem hiding this comment.
Thanks for the PR, overall looks good to me.
Only several minor comments inline.
Co-authored-by: YunLiu <55491388+KumoLiu@users.noreply.github.com> Signed-off-by: Ben Murray <ben.murray@gmail.com>
atbenmurray
approved these changes
Apr 23, 2024
Contributor
atbenmurray
left a comment
atbenmurray
left a comment
There was a problem hiding this comment.
Looks good with @KumoLiu's suggestions
Signed-off-by: Han Wang <freddie.wanah@gmail.com>
Contributor
Author
|
Thanks for the review. All prints have been removed. |
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Contributor
|
/build |
Contributor
|
Hi @freddiewanah, could you please fix the flake8 error, thanks. |
Signed-off-by: Han Wang <freddie.wanah@gmail.com>
Contributor
|
/build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed in PR #7609, I tried to break the suboptimal test refactors to smaller pieces. In this PR all asserts are checking textual content or instance of a parameter.
Suboptimal Assert: Instead of using statements such as assertIsNone, assertIsInstance, always simply use assertTrue or assertFalse. This will decrease the code overall readability and increase the execution time as extra logic needed.
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.