Skip to content

Add ResNet backbones for FlexibleUNet #7571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Apr 23, 2024
Merged

Add ResNet backbones for FlexibleUNet #7571

merged 16 commits into from
Apr 23, 2024

Conversation

@k-sukharev
Copy link
Contributor

@k-sukharev k-sukharev commented Mar 24, 2024

Fixes #7570.

Description

Add ResNet backbones (with option to use pretrained Med3D weights) for FlexibleUNet.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@k-sukharev
Add ResNet backbones for FlexibleUNet
99215ab 
Signed-off-by: Konstantin Sukharev <k.sukharev@gmail.com>
@k-sukharev
Add ResNetFeatures to docs
3531433 
Signed-off-by: Konstantin Sukharev <k.sukharev@gmail.com>
@k-sukharev
Fix types in type hints for ResNetFeatures
59eab7a 
Signed-off-by: Konstantin Sukharev <k.sukharev@gmail.com>
@k-sukharev k-sukharev marked this pull request as draft March 24, 2024 14:06
@k-sukharev
Remove useless arguments from ResNetFeatures __init__
0181bee 
Signed-off-by: Konstantin Sukharev <k.sukharev@gmail.com>
@k-sukharev
Fix tests if hf_hub_download is not installed
c66b875 
Signed-off-by: Konstantin Sukharev <k.sukharev@gmail.com>
@k-sukharev k-sukharev marked this pull request as ready for review March 24, 2024 17:38
@KumoLiu KumoLiu requested a review from binliunls April 1, 2024 07:58
binliunls
binliunls approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@binliunls binliunls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Leave a small comment.

k-sukharev and others added 3 commits April 13, 2024 23:29
@k-sukharev
Merge branch 'Project-MONAI:dev' into 7570-resnet-backbones-for-flexi…
9be24f5 
…ble-unet
@k-sukharev
Rename eff_net variable to feature_extractor_net
c445889 
Signed-off-by: Konstantin Sukharev <k.sukharev@gmail.com>
@k-sukharev
Update docstrings
4272f3f 
Signed-off-by: Konstantin Sukharev <k.sukharev@gmail.com>
@KumoLiu KumoLiu requested a review from binliunls April 15, 2024 02:22
@KumoLiu
Copy link
Contributor

KumoLiu commented Apr 17, 2024

/build

@KumoLiu
Copy link
Contributor

KumoLiu commented Apr 19, 2024

/build

1 similar comment
@KumoLiu
Copy link
Contributor

KumoLiu commented Apr 19, 2024

/build

@KumoLiu
Copy link
Contributor

KumoLiu commented Apr 22, 2024

/build

@KumoLiu KumoLiu enabled auto-merge (squash) April 22, 2024 02:48
@KumoLiu
Copy link
Contributor

KumoLiu commented Apr 22, 2024

/build

@KumoLiu
Copy link
Contributor

KumoLiu commented Apr 23, 2024

/build

@KumoLiu KumoLiu merged commit dc58e5c into Project-MONAI:dev Apr 23, 2024
@k-sukharev k-sukharev deleted the 7570-resnet-backbones-for-flexible-unet branch April 23, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@binliunls binliunls Awaiting requested review from binliunls

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add ResNetEncoder for FlexibleUNet

3 participants

@k-sukharev @KumoLiu @binliunls