Skip to content

Conversation

@yiheng-wang-nv
Copy link
Contributor

@yiheng-wang-nv yiheng-wang-nv commented Mar 15, 2024

Fixes #7540 .

Description

This PR:

  1. add logging file and meta file into BundleWorkflow
  2. add the sequence form of meta files check for ConfigWorkflow

Types of changes

  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

yiheng-wang-nv and others added 4 commits March 15, 2024 14:25
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
@yiheng-wang-nv yiheng-wang-nv marked this pull request as ready for review March 20, 2024 05:35
@yiheng-wang-nv yiheng-wang-nv requested review from KumoLiu and wyli March 20, 2024 05:36
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
@yiheng-wang-nv yiheng-wang-nv requested a review from Nic-Ma March 20, 2024 07:23
yiheng-wang-nv and others added 7 commits March 25, 2024 18:08
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Copy link
Member

@ericspod ericspod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@KumoLiu
Copy link
Contributor

KumoLiu commented Mar 27, 2024

For the CI error, may add something like this:

def get_workflow_type(self):

@KumoLiu
Copy link
Contributor

KumoLiu commented Mar 27, 2024

/build

@KumoLiu
Copy link
Contributor

KumoLiu commented Apr 1, 2024

/build

@KumoLiu KumoLiu enabled auto-merge (squash) April 1, 2024 07:51
@KumoLiu KumoLiu merged commit c885100 into Project-MONAI:dev Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add args in BundleWorkflow

3 participants