Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "properties_path" in BundleWorkflow #7542

Merged
merged 23 commits into from
Apr 1, 2024
Merged

Add "properties_path" in BundleWorkflow #7542

merged 23 commits into from
Apr 1, 2024

Conversation

KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Mar 13, 2024

Fixes #7541

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

KumoLiu and others added 6 commits March 13, 2024 15:16
@KumoLiu
add properties_path
129dc88 
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
remove ignite based properties
5aa4f38 
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
fix unittest
b2ea289 
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
cf34758 
for more information, see https://pre-commit.ci
@KumoLiu
fix ci
67670a1 
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
Merge branch 'bundle' of https://github.com/KumoLiu/MONAI into bundle
cca300e
@Nic-Ma
Copy link
Contributor

Nic-Ma commented Mar 13, 2024

Hi @KumoLiu ,

Please add more description in the issue #7541 to help @ericspod and others understand the user stories and discuss.

Thanks in advance.

@yiheng-wang-nv yiheng-wang-nv mentioned this pull request Mar 21, 2024
Closed
8 tasks
@KumoLiu
Merge remote-tracking branch 'yliu/bundle' into bundle
e941dde
@KumoLiu
Revert "Merge remote-tracking branch 'yliu/bundle' into bundle"
06d9a34 
This reverts commit e941dde, reversing
changes made to 5aa4f38.
@KumoLiu
Revert "Revert "Merge remote-tracking branch 'yliu/bundle' into bundle""
22735af 
This reverts commit 06d9a34.
@KumoLiu
Revert "Merge remote-tracking branch 'yliu/bundle' into bundle"
e274826 
This reverts commit e941dde, reversing
changes made to 5aa4f38.
@KumoLiu
Revert "Merge branch 'bundle' of https://github.com/KumoLiu/MONAI int…
d671512 
…o bundle"

This reverts commit cca300e, reversing
changes made to 67670a1.
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
Revert "remove ignite based properties"
ca90a4b 
This reverts commit 5aa4f38.
@KumoLiu
DCO Remediation Commit for YunLiu <55491388+KumoLiu@users.noreply.git…
6526f59 
…hub.com>

I, YunLiu <55491388+KumoLiu@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 06d9a34
I, YunLiu <55491388+KumoLiu@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 22735af
I, YunLiu <55491388+KumoLiu@users.noreply.github.com>, hereby add my Signed-off-by to this commit: e274826
I, YunLiu <55491388+KumoLiu@users.noreply.github.com>, hereby add my Signed-off-by to this commit: ca90a4b

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
Merge branch 'dev' into bundle
cc61a92
@KumoLiu
fix flake8
54ac375 
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
add determinism for mixup
40bb130 
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
fix mypy
5e6edaa 
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu KumoLiu requested a review from ericspod March 27, 2024 05:09
Nic-Ma
Nic-Ma reviewed Mar 27, 2024
View reviewed changes
monai/bundle/workflows.py Outdated Show resolved Hide resolved
@KumoLiu
add unittest
918cb77 
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
Merge remote-tracking branch 'origin/dev' into bundle
5a90086
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Mar 27, 2024

/build

@KumoLiu
Merge remote-tracking branch 'yliu/bundle' into bundle
b7a21b0
@KumoLiu
Merge branch 'dev' into bundle
a717800 
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Apr 1, 2024

/build

@KumoLiu
fix ci
b320035 
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Apr 1, 2024

/build

@KumoLiu KumoLiu merged commit 264b9e4 into Project-MONAI:dev Apr 1, 2024
27 of 28 checks passed
@KumoLiu KumoLiu deleted the bundle branch April 1, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nic-Ma Nic-Ma Nic-Ma approved these changes

@yiheng-wang-nv yiheng-wang-nv Awaiting requested review from yiheng-wang-nv

@binliunls binliunls Awaiting requested review from binliunls

@wyli wyli Awaiting requested review from wyli

@ericspod ericspod Awaiting requested review from ericspod

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add "properties_path" in BundleWorkflow
3 participants
@KumoLiu @Nic-Ma @ericspod