-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Auto3DSeg] Add mlflow support in autorunner. #7176
[Auto3DSeg] Add mlflow support in autorunner. #7176
Conversation
for more information, see https://pre-commit.ci
…yang0122/MONAI into auto3dseg_autorunner_mlflow
I think this should be a part of kwargs of Autorunner, instead of adding more names parameters for very specific use case. Then you check for it as |
@myron @dongyang0122 As the zen of python says "explicit is better than implicit". In my opinion, having more names means better documentation. Deferring to kwargs usually makes sense when dealing with a third party parameters that might change over time without our notice, but mlflow_tracking_uri is our parameter and we decide how to use it (although we are passing it to mlflow). |
I acknowledge the perspectives presented from both sides. Incorporating an input variable |
Hi @drbeh , @dongyang0122 , Do we have any usecase to allow users to set Thanks. |
/black |
/build |
/build |
1 similar comment
/build |
Add MLflow support in AutoRunner Class. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: dongy <dongy@nvidia.com> Signed-off-by: Mark Graham <markgraham539@gmail.com>
Add MLflow support in AutoRunner Class. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: dongy <dongy@nvidia.com> Signed-off-by: Yu0610 <612410030@alum.ccu.edu.tw>
Add MLflow support in AutoRunner Class.
Types of changes
./runtests.sh -f -u --net --coverage
../runtests.sh --quick --unittests --disttests
.make html
command in thedocs/
folder.