-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[WIP] Port MONAI Generative utils #7134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Port MONAI Generative utils #7134
Conversation
@ericspod I'm getting mypy errors from
so far they only operate on tensors - am I ok to type them specifally for tensors/np arrays to satisfy mypy? |
If you need to yes do that, but we do have NdarrayOrTensor. |
I, Mark Graham <markgraham539@gmail.com>, hereby add my Signed-off-by to this commit: 7aaeab0 I, Mark Graham <markgraham539@gmail.com>, hereby add my Signed-off-by to this commit: 2090549 I, Mark Graham <markgraham539@gmail.com>, hereby add my Signed-off-by to this commit: 94f57ac I, Mark Graham <markgraham539@gmail.com>, hereby add my Signed-off-by to this commit: f94e666 I, Mark Graham <markgraham539@gmail.com>, hereby add my Signed-off-by to this commit: 1d95d92 I, Mark Graham <markgraham539@gmail.com>, hereby add my Signed-off-by to this commit: 355b4d9 I, Mark Graham <markgraham539@gmail.com>, hereby add my Signed-off-by to this commit: 92044d5 Signed-off-by: Mark Graham <markgraham539@gmail.com>
for more information, see https://pre-commit.ci
Signed-off-by: Mark Graham <markgraham539@gmail.com>
…ONAI into 6676_port_generative_utils
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, few minor comments inline.
Signed-off-by: Mark Graham <markgraham539@gmail.com>
I, Mark Graham <markgraham539@gmail.com>, hereby add my Signed-off-by to this commit: f71fda0 Signed-off-by: Mark Graham <markgraham539@gmail.com>
Signed-off-by: Mark Graham <markgraham539@gmail.com>
Signed-off-by: Mark Graham <markgraham539@gmail.com>
/build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, it looks good to me.
Towards completing #6676 .
Description
A few sentences describing the changes proposed in this pull request.
Types of changes
./runtests.sh -f -u --net --coverage
../runtests.sh --quick --unittests --disttests
.make html
command in thedocs/
folder.