Signalfillempty set track_meta to True #7089
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #7011. I was using the
Signalfillemptyd
(based onSignalfillempty
) transform in monailabel and found out, it currently allows no inversion.When digging deeper I realized that SignalFillEmpty just throws away the meta information.
With the simple addition of
track_meta=True
it works as expected.I hope it has no other impact, but I honestly don't know.
@wyli would be cool if we can add this to MONAI 1.3.0, thanks! I can also rework
Signalfillempty
to just accept any datatype, if that would the more appropriate approach.Types of changes
make html
command in thedocs/
folder../runtests.sh -f -u --net --coverage
../runtests.sh --quick --unittests --disttests
.