Remove deprecated args and class for v1.3 #7019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: KumoLiu <yunl@nvidia.com>
for more information, see https://pre-commit.ci
KumoLiu
commented
Sep 21, 2023
|
thanks, we may consider updating the default value here: MONAI/monai/transforms/io/array.py Line 130 in f3200b9 |
Signed-off-by: KumoLiu <yunl@nvidia.com>
for more information, see https://pre-commit.ci
Signed-off-by: KumoLiu <yunl@nvidia.com>
for more information, see https://pre-commit.ci
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
wyli
reviewed
Sep 22, 2023
Signed-off-by: KumoLiu <yunl@nvidia.com>
wyli
approved these changes
Sep 22, 2023
|
/build |
5 tasks
wyli
pushed a commit
to Project-MONAI/tutorials
that referenced
this pull request
Sep 25, 2023
### Description After Project-MONAI/MONAI#7019, `AsChannelFirst` and `AddChannel` have been deprecated, remove the usage in the tutorial. ### Checks <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [ ] Avoid including large-size files in the PR. - [ ] Clean up long text outputs from code cells in the notebook. - [ ] For security purposes, please check the contents and remove any sensitive info such as user names and private key. - [ ] Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the `./figure` folder - [ ] Notebook runs automatically `./runner.sh -t <path to .ipynb file>` --------- Signed-off-by: KumoLiu <yunl@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
5 tasks
wyli
pushed a commit
to Project-MONAI/tutorials
that referenced
this pull request
Sep 26, 2023
Fixes #1529 ### Description Update `image_only=False` in `LoadImaged` since the default value of `image_only` has been changed by Project-MONAI/MONAI#7019 ### Checks <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Avoid including large-size files in the PR. - [x] Clean up long text outputs from code cells in the notebook. - [ ] For security purposes, please check the contents and remove any sensitive info such as user names and private key. - [ ] Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the `./figure` folder - [ ] Notebook runs automatically `./runner.sh -t <path to .ipynb file>` Signed-off-by: KumoLiu <yunl@nvidia.com>
boneseva
pushed a commit
to boneseva/MONAI-tutorials
that referenced
this pull request
Apr 21, 2024
### Description After Project-MONAI/MONAI#7019, `AsChannelFirst` and `AddChannel` have been deprecated, remove the usage in the tutorial. ### Checks <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [ ] Avoid including large-size files in the PR. - [ ] Clean up long text outputs from code cells in the notebook. - [ ] For security purposes, please check the contents and remove any sensitive info such as user names and private key. - [ ] Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the `./figure` folder - [ ] Notebook runs automatically `./runner.sh -t <path to .ipynb file>` --------- Signed-off-by: KumoLiu <yunl@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boneseva
pushed a commit
to boneseva/MONAI-tutorials
that referenced
this pull request
Apr 21, 2024
Fixes Project-MONAI#1529 ### Description Update `image_only=False` in `LoadImaged` since the default value of `image_only` has been changed by Project-MONAI/MONAI#7019 ### Checks <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Avoid including large-size files in the PR. - [x] Clean up long text outputs from code cells in the notebook. - [ ] For security purposes, please check the contents and remove any sensitive info such as user names and private key. - [ ] Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the `./figure` folder - [ ] Notebook runs automatically `./runner.sh -t <path to .ipynb file>` Signed-off-by: KumoLiu <yunl@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7018.
Description
compute_meaniouAsChannelFirst,AddChannelandSplitChannelcreate_multigpu_supervised_trainerandcreate_multigpu_supervised_evaluatordata_src_cfg_filenameinAlgoEnsembleBuilderrunner_idinrunepoch_intervalanditeration_intervalinTensorBoardStatsHandlerget_validation_statsinEvaluatorget_train_statsinTrainernametoStatsHandlerinStatsHandlerrandom_sizetoFalseinRandSpatialCrop,RandScaleCrop,RandSpatialCropSamplesimage_onlytoTrueinLoadImageandSaveImageMetaTenorrelated deprecationTypes of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.