Skip to content

Conversation

@nvkevlu
Copy link
Contributor

@nvkevlu nvkevlu commented Sep 13, 2023

PR #6220 was closed and NVFlareStatsHandler has now been implemented in NVFlare in NVIDIA/NVFlare#1925. However, there is still the piece in MonaiAlgo to attach the stats_sender in initialize, so this PR adds that missing piece.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@nvkevlu nvkevlu requested a review from holgerroth September 13, 2023 19:09
Signed-off-by: Kevin <kevlu@nvidia.com>
Copy link

@yanchengnv yanchengnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments.

nvkevlu and others added 2 commits September 13, 2023 15:56
Copy link

@yanchengnv yanchengnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wyli
Copy link
Contributor

wyli commented Sep 13, 2023

/build

@wyli wyli enabled auto-merge (squash) September 13, 2023 20:45
@wyli wyli merged commit 6dfe17a into Project-MONAI:dev Sep 13, 2023
@nvkevlu nvkevlu deleted the add_fl_stats_sender branch September 13, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants