Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add freeze_layers #6970

Merged
merged 6 commits into from
Sep 12, 2023
Merged

Add freeze_layers #6970

merged 6 commits into from
Sep 12, 2023

Conversation

KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Sep 12, 2023 •
edited
Loading

Part of #6552.

Description

Add freeze_layers.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

KumoLiu and others added 4 commits September 12, 2023 14:59
@KumoLiu
add freeze_layers
c115b77 
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu
add unittests
bd87230 
Signed-off-by: KumoLiu <yunl@nvidia.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
e4419c7 
for more information, see https://pre-commit.ci
@KumoLiu
add exclude_vars
ea2f3c2 
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu KumoLiu marked this pull request as ready for review September 12, 2023 08:28
@KumoLiu
address comments
d1ec802 
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu
fix flake8
c6afba3 
Signed-off-by: KumoLiu <yunl@nvidia.com>
wyli
wyli approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@wyli
Copy link
Contributor

wyli commented Sep 12, 2023

/build

@wyli wyli enabled auto-merge (squash) September 12, 2023 14:59
@wyli wyli merged commit 66f42c1 into Project-MONAI:dev Sep 12, 2023
32 checks passed
@KumoLiu KumoLiu deleted the freeze branch September 13, 2023 04:01
vikashg
vikashg reviewed Sep 14, 2023
View reviewed changes
Copy link

@vikashg vikashg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @KumoLiu Looks great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikashg vikashg vikashg left review comments

@wyli wyli wyli approved these changes

@ericspod ericspod Awaiting requested review from ericspod

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KumoLiu @wyli @vikashg