Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6962 Fix bundle download naming issue #6969

Merged

Conversation

yiheng-wang-nv
Copy link
Contributor

Fixes #6962 .

Description

This PR is used to fix the bundle download issue if using monaihosting source. Detailed information is attached in #6962 .

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Copy link
Contributor

@KumoLiu KumoLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@yiheng-wang-nv
Copy link
Contributor Author

/black

Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
@wyli
Copy link
Contributor

wyli commented Sep 11, 2023

/build

@wyli wyli enabled auto-merge (squash) September 11, 2023 06:12
@wyli wyli merged commit 5b9d24e into Project-MONAI:dev Sep 11, 2023
30 of 32 checks passed
@yiheng-wang-nv yiheng-wang-nv deleted the 6962-fix-bundle-download-naming-issue branch September 11, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bundle download failed
4 participants