Skip to content

Fix reading dicom series error in ITKReader #6943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 5, 2023
Merged

Fix reading dicom series error in ITKReader #6943

merged 7 commits into from
Sep 5, 2023

Conversation

@KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Sep 5, 2023 •
edited by wyli
Loading

Fixes #6942
fixes #6944.

Description

When using itk backend reading dicom series and there is only one file in the folder, return the first name since itk assuming that there must be more than one file in the tuple.
https://github.com/InsightSoftwareConsortium/ITK/blob/452cb3f9716e95532200de3196d51cd705a0ec5e/Wrapping/Generators/Python/itk/support/extras.py#L1275-L1284

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@KumoLiu
fix Project-MONAI#6942
b54ab19 
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu
fix mypy
39b1b8a 
Signed-off-by: KumoLiu <yunl@nvidia.com>
wyli
wyli reviewed Sep 5, 2023
View reviewed changes
@KumoLiu
add unittest; fix Project-MONAI#6944
7a3ddc7 
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu KumoLiu requested review from Nic-Ma and ericspod September 5, 2023 09:35
KumoLiu and others added 4 commits September 5, 2023 18:12
wyli
wyli approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@wyli wyli enabled auto-merge (squash) September 5, 2023 10:49
@wyli
Copy link
Contributor

wyli commented Sep 5, 2023

/build

@wyli wyli merged commit 8e77e03 into Project-MONAI:dev Sep 5, 2023
@KumoLiu KumoLiu deleted the itkreader branch September 5, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

@ericspod ericspod Awaiting requested review from ericspod ericspod is a code owner

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma Nic-Ma is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect spacing is recorded when reading single pydicom dataset object with pydicom Get error when reading dicom series with itk backend

2 participants

@KumoLiu @wyli