Skip to content

6873 data analyzer histogram_only=True fix #6874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 16, 2023
Merged

6873 data analyzer histogram_only=True fix #6874

merged 2 commits into from
Aug 16, 2023

Conversation

@wyli
Copy link
Contributor

@wyli wyli commented Aug 15, 2023

Fixes #6873

Description

  • fixes data analyzer
  • replace "image_stats" with DataStatsKeys.IMAGE_STATS

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli
fixes Project-MONAI#6873
c46dbf7 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli marked this pull request as ready for review August 15, 2023 19:33
@mingxin-zheng
Copy link
Contributor

mingxin-zheng commented Aug 16, 2023

Thank you @wyli . Looks good to me!

@wyli
Copy link
Contributor Author

wyli commented Aug 16, 2023

/build

@wyli wyli enabled auto-merge (squash) August 16, 2023 10:33
@wyli
Copy link
Contributor Author

wyli commented Aug 16, 2023

/build

@wyli wyli merged commit 617c1be into Project-MONAI:dev Aug 16, 2023
@wyli wyli deleted the fixes-6873 branch August 16, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mingxin-zheng mingxin-zheng mingxin-zheng approved these changes

@ericspod ericspod Awaiting requested review from ericspod ericspod is a code owner

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma Nic-Ma is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DataAnalyzer with histogram_only=True

2 participants

@wyli @mingxin-zheng