Skip to content

Add CallableEventWithFilter support to GarbageCollector #6663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 28, 2023
Merged

Add CallableEventWithFilter support to GarbageCollector #6663

merged 6 commits into from
Jun 28, 2023

Conversation

@matt3o
Copy link
Contributor

@matt3o matt3o commented Jun 27, 2023 •
edited
Loading

Fixes # .

Description

Adds support for CallableEventWithFilter which is useful for not calling the GarbageCollector every iteration but e.g. every 10 iterations.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

matt3o added 3 commits June 27, 2023 14:02
@matt3o
Add CallableEventWithFilter support to GarbageCollector
1bc6245 
Signed-off-by: Matthias Hadlich <matthiashadlich@posteo.de>
@matt3o
Fix imports for GarbageCollector
6bc5ab6 
Signed-off-by: Matthias Hadlich <matthiashadlich@posteo.de>
@matt3o
Fix garbage_collector.py
b7dd86b 
Signed-off-by: Matthias Hadlich <matthiashadlich@posteo.de>
@wyli
Copy link
Contributor

wyli commented Jun 28, 2023

/black

monai-bot and others added 3 commits June 28, 2023 07:28
@monai-bot
[MONAI] code formatting
2d161e6 
Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
@matt3o
Fix typing for GarbageCollector
e4e2823 
Signed-off-by: Matthias Hadlich <matthiashadlich@posteo.de>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
f910ace 
for more information, see https://pre-commit.ci
wyli
wyli approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@matt3o matt3o marked this pull request as ready for review June 28, 2023 08:55
@wyli
Copy link
Contributor

wyli commented Jun 28, 2023

/build

@wyli wyli enabled auto-merge (squash) June 28, 2023 09:07
@wyli wyli merged commit 59470e4 into Project-MONAI:dev Jun 28, 2023
@matt3o matt3o deleted the Update-GarbageCollector branch June 28, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@matt3o @wyli @monai-bot