Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make RetinaNet throw errors for NaN only when training #6479

Merged
merged 2 commits into from
May 5, 2023

Conversation

mingxin-zheng
Copy link
Contributor

Fixes #6478 .

Description

I assume that the amp=True setting affects the numeric stability in evaluators and causes the issues in #6478 ,

The fix in this PR aims to continue the training by not raising errors during the evaluation.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).

Signed-off-by: Mingxin Zheng <18563433+mingxin-zheng@users.noreply.github.com>
Copy link
Collaborator

@Can-Zhao Can-Zhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you!

@wyli
Copy link
Contributor

wyli commented May 5, 2023

/build

@wyli wyli enabled auto-merge (squash) May 5, 2023 19:45
@wyli wyli merged commit d688769 into Project-MONAI:dev May 5, 2023
@mingxin-zheng mingxin-zheng requested review from wyli and Nic-Ma and removed request for wyli and Nic-Ma May 6, 2023 01:28
@mingxin-zheng
Copy link
Contributor Author

My page did not refresh so I made wrong requests. Sorry for the bother @wyli @Nic-Ma

@mingxin-zheng mingxin-zheng deleted the fix-6478-nan branch May 10, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: NaN stops evaluation in detection with a small dataset
3 participants