Skip to content

Conversation

@wyli
Copy link
Contributor

@wyli wyli commented Apr 25, 2023

Fixes #6222

Description

nonbreaking change extending the current mode+padding mode combinations.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

wyli added 6 commits April 25, 2023 17:14
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli marked this pull request as ready for review April 25, 2023 17:44
@wyli wyli requested review from KumoLiu, Nic-Ma and ericspod April 25, 2023 17:44
@atbenmurray atbenmurray self-requested a review April 25, 2023 18:27
@atbenmurray
Copy link
Contributor

atbenmurray commented Apr 25, 2023

@wyli This looks promising. Is the full plan for this that the applying of lazy transforms will also make use of it?

wyli added 2 commits April 25, 2023 16:08
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor Author

wyli commented Apr 25, 2023

/build

@wyli wyli merged commit 5991b83 into Project-MONAI:dev Apr 26, 2023
@wyli wyli deleted the unify-modes branch April 26, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

spatial resample -- adaptive padding mode when switching the backends

4 participants