Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6086 6087 nan to indicate no_channel, split dim singleton #6090

Merged
merged 3 commits into from
Mar 2, 2023

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Mar 1, 2023

Description

Fixes #6086 remove the channel check
Fixes #6087 internally using float('nan') to also represent "no_channel"

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

wyli added 2 commits March 1, 2023 21:49
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor Author

wyli commented Mar 1, 2023

/build

@wyli wyli marked this pull request as ready for review March 1, 2023 22:25
@Nic-Ma
Copy link
Contributor

Nic-Ma commented Mar 2, 2023

Hi @wyli ,

Could you please help explain more about the use case to collate a "no-channel" Tensor and a "channel-first" Tensor?

Thanks in advance.

@wyli
Copy link
Contributor Author

wyli commented Mar 2, 2023

Both issues are from dealing with a dataset that has both no-channel gray-scale images and 3-channel RGB images in PNG files

@wyli wyli closed this Mar 2, 2023
@wyli wyli reopened this Mar 2, 2023
@wyli
Copy link
Contributor Author

wyli commented Mar 2, 2023

/build

@wyli wyli enabled auto-merge (squash) March 2, 2023 20:33
@wyli wyli merged commit 10faf46 into Project-MONAI:dev Mar 2, 2023
@wyli wyli deleted the 6087 branch March 7, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ORIGINAL_CHANNEL_DIM datatype for collate SplitDim support chns==1
2 participants