Skip to content

5902 allow for missing filename_or_obj key #5980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 13, 2023
Merged

5902 allow for missing filename_or_obj key #5980

merged 2 commits into from
Feb 13, 2023

Conversation

@wyli
Copy link
Contributor

@wyli wyli commented Feb 11, 2023

Signed-off-by: Wenqi Li wenqil@nvidia.com

Fixes #5902

Description

the source image in ResampleToMatch may not have a filename_or_obj when the source image is not created from LoadImage

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

wyli added 2 commits February 11, 2023 16:02
@wyli
allow for missing filename_or_obj key
1d49fde 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
update
f5df916 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Nic-Ma
Nic-Ma approved these changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @KumoLiu , could you please help double-confirm this PR?

Thanks in advance.

Nic-Ma
Nic-Ma reviewed Feb 13, 2023
View reviewed changes
@wyli
Copy link
Contributor Author

wyli commented Feb 13, 2023

/build

@wyli wyli enabled auto-merge (squash) February 13, 2023 07:59
@wyli wyli merged commit 71abf1b into Project-MONAI:dev Feb 13, 2023
@wyli wyli deleted the 5902-filename-or-obj branch February 13, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nic-Ma Nic-Ma Nic-Ma approved these changes

@KumoLiu KumoLiu KumoLiu approved these changes

@ericspod ericspod Awaiting requested review from ericspod ericspod is a code owner

@rijobro rijobro Awaiting requested review from rijobro

@yiheng-wang-nv yiheng-wang-nv Awaiting requested review from yiheng-wang-nv

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ResampleToMatch shouldn't always require FILENAME_OR_OBJ

3 participants

@wyli @Nic-Ma @KumoLiu