Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added callable options for iteration_log and epoch_log in TensorBoard and MLFlow #5976

Merged
merged 7 commits into from
Feb 20, 2023
Merged

Added callable options for iteration_log and epoch_log in TensorBoard and MLFlow #5976

merged 7 commits into from
Feb 20, 2023

Conversation

vfdev-5
Copy link
Member

@vfdev-5 vfdev-5 commented Feb 10, 2023 •
edited
Loading

Follow-up PR on extending iteration_log/epoch_log functionality

Description

Could you please help also enable this feature for other very similar handlers? Like:
https://github.com/Project-MONAI/MONAI/blob/dev/monai/handlers/tensorboard_handlers.py#L94
And:
https://github.com/Project-MONAI/MONAI/blob/dev/monai/handlers/mlflow_handler.py#L101

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@vfdev-5 vfdev-5 marked this pull request as ready for review February 10, 2023 11:26
@vfdev-5 vfdev-5 requested a review from Nic-Ma February 10, 2023 11:26
@wyli
Merge remote-tracking branch 'upstream/dev' into tb-mflow-override-args
d09657f 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
fixes deprected version
36affc7 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor

wyli commented Feb 20, 2023

/build

@wyli
testing deprecated errors
d33d403 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor

wyli commented Feb 20, 2023

/build

@wyli wyli enabled auto-merge (squash) February 20, 2023 15:54
@wyli
Copy link
Contributor

wyli commented Feb 20, 2023

/build

@wyli wyli merged commit 88fb0b1 into Project-MONAI:dev Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyli wyli wyli left review comments

@Nic-Ma Nic-Ma Nic-Ma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vfdev-5 @wyli @Nic-Ma