Fix instantiate for object instantiation with attribute path
#5866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surajpaib
changed the title
pathpath
wyli
approved these changes
Jan 18, 2023
Contributor
wyli
left a comment
wyli
left a comment
There was a problem hiding this comment.
Thanks, could you please signoff the commit with "git commit --signoff" https://github.com/Project-MONAI/MONAI/blob/dev/CONTRIBUTING.md#signing-your-work
The flake8 style error is irrelevant, I'll change the style config when merging this PR
Nic-Ma
reviewed
Jan 18, 2023
Signed-off-by: Suraj Pai <bspai@bwh.harvard.edu>
Contributor
|
/build |
wyli
changed the title
pathpath
Nic-Ma
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5865
-- also fixes #5868 to unblock premerge
Description
A few sentences describing the changes proposed in this pull request.
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.