Make RandTorchVisiond and RandCuCIMd Consistent #5569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SachidanandAlle
previously approved these changes
Nov 23, 2022
bhashemian
force-pushed
the
update-rand-wrappers
branch
from
d3fa0aa to
f343cee
Compare
bhashemian
force-pushed
the
update-rand-wrappers
branch
from
f343cee to
68b78d2
Compare
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
wyli
reviewed
Nov 23, 2022
Contributor
|
I agree on that naming part.. let it consistent across all other transforms unless prob field is already taken by some torch vision function (as we r passing kwargs) |
SachidanandAlle
dismissed
their stale review
Logically looks ok to me.. I will let others to decide on standard convention and approve
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
wyli
approved these changes
Dec 5, 2022
Contributor
|
/build |
wyli
reviewed
Dec 5, 2022
Co-authored-by: Wenqi Li <831580+wyli@users.noreply.github.com>
Contributor
|
/black |
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
…update-rand-wrappers
Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
Contributor
|
/build |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Both RandTorchVisiond and RandCuCIMd are dealing with the third-party libraries and they should have the same API, especially on using
apply_probinstead ofprobsince it is different than theprobof the underlying randomized tranform.Types of changes