Skip to content

5127 fixes dtypes in randomized transforms #5129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Sep 12, 2022

Signed-off-by: Wenqi Li wenqil@nvidia.com

Fixes #5127

Description

still does the dtype converting if self._do_transform is False

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor Author

wyli commented Sep 12, 2022

Screenshot 2022-09-12 at 15 59 02

integration works fine

@wyli wyli marked this pull request as ready for review September 12, 2022 15:05
@wyli
Copy link
Contributor Author

wyli commented Sep 12, 2022

/build

@wyli wyli merged commit 5375a74 into Project-MONAI:dev Sep 12, 2022
@wyli wyli deleted the 5127-randrotate-dtype branch September 12, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RandRotated transform error
2 participants