Skip to content

norm_eps defined in class SPADEResBlock init is not used #7946

Closed
@mingxin-zheng

Description

@mingxin-zheng

Describe the bug

In the init of SPADEResBlock

norm_eps was defined but not used in the class methods.

To Reproduce
Steps to reproduce the behavior:
None

Expected behavior
The SPADE layer should take the eps for the GroupNorm:
Current:

        self.norm1 = SPADE(
            label_nc=label_nc,
            norm_nc=in_channels,
            norm="GROUP",
            norm_params={"num_groups": norm_num_groups, "affine": False},
            hidden_channels=spade_intermediate_channels,
            kernel_size=3,
            spatial_dims=spatial_dims,
        )

Expected:

        self.norm1 = SPADE(            
            label_nc=label_nc,            
            norm_nc=in_channels,            
            norm="GROUP",            
            norm_params={"num_groups": norm_num_groups, "affine": False, "eps": norm_eps},            
            hidden_channels=spade_intermediate_channels,            
            kernel_size=3,            
            spatial_dims=spatial_dims,        
        )

Metadata

Metadata

Labels

bugSomething isn't workinggood first issueGood for newcomers

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions