Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DistributedWeightedRandomSampler remove shuffle=False option #6885

Closed
wyli opened this issue Aug 17, 2023 · 1 comment · Fixed by #6886
Closed

DistributedWeightedRandomSampler remove shuffle=False option #6885

wyli opened this issue Aug 17, 2023 · 1 comment · Fixed by #6886
Assignees
@AmirAflak
Labels
Contribution wanted Feature request good first issue Good for newcomers

Comments

@wyli
Copy link
Contributor

wyli commented Aug 17, 2023

Describe the bug

MONAI/monai/data/samplers.py

Line 98 in 4cd717c

shuffle: bool = True,

the random sampler will always generate 'shuffled' outputs, the shuffle=False option is not valid and should be removed
@AmirAflak
Copy link
Contributor

Would like to take this.

@AmirAflak AmirAflak mentioned this issue Aug 17, 2023
Merged
7 tasks
wyli pushed a commit that referenced this issue Aug 18, 2023
@AmirAflak @monai-bot
remove: shuffle=False option (#6886)
6e47140 
Fixes #6885 

### Description

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: Amirreza Aflakparast <84932095+AmirAflak@users.noreply.github.com>
Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
Co-authored-by: monai-bot <monai.miccai2019@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AmirAflak AmirAflak

Labels
Contribution wanted Feature request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove: shuffle=False option AmirAflak/MONAI
2 participants
@wyli @AmirAflak