-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong spacing checking logic in DICOM series combination #6630
Labels
bug
Something isn't working
Comments
thanks for reporting, would you like to submit a PR to fix it? I think the relevant elementwise checks could be done with allclose
|
Hi, I can make a PR later. |
function2-llx
added a commit
to function2-llx/MONAI
that referenced
this issue
Jun 27, 2023
function2-llx
added a commit
to function2-llx/MONAI
that referenced
this issue
Jun 27, 2023
Signed-off-by: function2 <function2-llx@outlook.com>
wyli
pushed a commit
that referenced
this issue
Jun 27, 2023
Fixes #6630. ### Description Fix DICOM series combining checking ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [x] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. --------- Signed-off-by: function2 <function2-llx@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
I found some issues in the following code snip:
MONAI/monai/data/image_reader.py
Lines 510 to 521 in 2cbed6c
slices[idx]
instead offirst_slice
; there's the same issue in line 521;[1.0, 1.0, 1.0]
, which is alist
instance, while the default value in line 520 is(1.0, 1.0, 1.0)
, which is atuple
instance, and(1.0, 1.0, 1.0) == [1.0, 1.0, 1.0]
will result inFalse
.The text was updated successfully, but these errors were encountered: