resolve comment of meta_file

Signed-off-by: Yiheng Wang <vennw@nvidia.com>

Author: yiheng-wang-nv

monai/bundle/workflows.py

@@ -91,11 +91,19 @@ def __init__(
 
         if meta_file is not None:
             if isinstance(meta_file, str) and not os.path.isfile(meta_file):
-                raise FileNotFoundError(f"Cannot find the metadata config file: {meta_file}.")
+                logger.error(
+                    f"Cannot find the metadata config file: {meta_file}. "
+                    "Please see: https://docs.monai.io/en/stable/mb_specification.html"
+                )
+                meta_file = None
             if isinstance(meta_file, list):
                 for f in meta_file:
                     if not os.path.isfile(f):
-                        raise FileNotFoundError(f"Cannot find the metadata config file: {f}.")
+                        logger.error(
+                            f"Cannot find the metadata config file: {f}. "
+                            "Please see: https://docs.monai.io/en/stable/mb_specification.html"
+                        )
+                        meta_file = None
 
         self.meta_file = meta_file
 
@@ -258,22 +266,23 @@ def __init__(
         **override: Any,
     ) -> None:
         workflow_type = workflow if workflow is not None else workflow_type
-        super().__init__(workflow_type=workflow_type)
         if config_file is not None:
             _config_files = ensure_tuple(config_file)
-            self.config_root_path = Path(_config_files[0]).parent
+            config_root_path = Path(_config_files[0]).parent
             for _config_file in _config_files:
                 _config_file = Path(_config_file)
-                if _config_file.parent != self.config_root_path:
+                if _config_file.parent != config_root_path:
                     logger.warn(
-                        f"Not all config files are in {self.config_root_path}. If logging_file and meta_file are"
-                        f"not specified, {self.config_root_path} will be used as the default config root directory."
+                        f"Not all config files are in {config_root_path}. If logging_file and meta_file are"
+                        f"not specified, {config_root_path} will be used as the default config root directory."
                     )
                 if not _config_file.is_file():
                     raise FileNotFoundError(f"Cannot find the config file: {_config_file}.")
         else:
-            self.config_root_path = Path("configs")
-
+            config_root_path = Path("configs")
+        meta_file = str(config_root_path / "metadata.json") if meta_file is None else meta_file
+        super().__init__(workflow_type=workflow_type, meta_file=meta_file)
+        self.config_root_path = config_root_path
         logging_file = str(self.config_root_path / "logging.conf") if logging_file is None else logging_file
         if logging_file is not None:
             if not os.path.isfile(logging_file):
@@ -287,21 +296,8 @@ def __init__(
 
         self.parser = ConfigParser()
         self.parser.read_config(f=config_file)
-        meta_file = str(self.config_root_path / "metadata.json") if meta_file is None else meta_file
-        if isinstance(meta_file, str) and not os.path.isfile(meta_file):
-            logger.error(
-                f"Cannot find the metadata config file: {meta_file}. "
-                "Please see: https://docs.monai.io/en/stable/mb_specification.html"
-            )
-        elif isinstance(meta_file, list):
-            for f in meta_file:
-                if not os.path.isfile(f):
-                    logger.error(
-                        f"Cannot find the metadata config file: {f}. "
-                        "Please see: https://docs.monai.io/en/stable/mb_specification.html"
-                    )
-        else:
-            self.parser.read_meta(f=meta_file)
+        if self.meta_file is not None:
+            self.parser.read_meta(f=self.meta_file)
 
         # the rest key-values in the _args are to override config content
         self.parser.update(pairs=override)

tests/test_bundle_workflow.py

@@ -11,6 +11,7 @@
 
 from __future__ import annotations
 
+import logging
 import os
 import shutil
 import tempfile
@@ -37,10 +38,6 @@
 
 TEST_CASE_NON_CONFIG_WRONG_LOG = [None, "logging.conf", "Cannot find the logging config file: logging.conf."]
 
-TEST_CASE_NON_CONFIG_WRONG_META = ["meta.json", None, "Cannot find the metadata config file: meta.json."]
-
-TEST_CASE_NON_CONFIG_WRONG_META_LIST = [["meta.json"], None, "Cannot find the metadata config file: meta.json."]
-
 
 class TestBundleWorkflow(unittest.TestCase):
 
@@ -153,10 +150,8 @@ def test_non_config(self):
         self.assertEqual(inferer.meta_file, None)
         self._test_inferer(inferer)
 
-    @parameterized.expand(
-        [TEST_CASE_NON_CONFIG_WRONG_META, TEST_CASE_NON_CONFIG_WRONG_META_LIST, TEST_CASE_NON_CONFIG_WRONG_LOG]
-    )
-    def test_non_config_wrong_cases(self, meta_file, logging_file, expected_error):
+    @parameterized.expand([TEST_CASE_NON_CONFIG_WRONG_LOG])
+    def test_non_config_wrong_log_cases(self, meta_file, logging_file, expected_error):
         with self.assertRaisesRegex(FileNotFoundError, expected_error):
             NonConfigWorkflow(self.filename, self.data_dir, meta_file, logging_file)