Skip to content

Commit e604d18

Browse files
authored
Fix TypeError in meshgrid (#8252)
Fixes #8251 Remove `indexing="ij"` will not affect anything since it's default behavior in torch. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
1 parent 9808ce2 commit e604d18

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

monai/networks/blocks/pos_embed_utils.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ def build_sincos_position_embedding(
5656
grid_h = torch.arange(h, dtype=torch.float32)
5757
grid_w = torch.arange(w, dtype=torch.float32)
5858

59-
grid_h, grid_w = torch.meshgrid(grid_h, grid_w, indexing="ij")
59+
grid_h, grid_w = torch.meshgrid(grid_h, grid_w)
6060

6161
if embed_dim % 4 != 0:
6262
raise AssertionError("Embed dimension must be divisible by 4 for 2D sin-cos position embedding")
@@ -75,7 +75,7 @@ def build_sincos_position_embedding(
7575
grid_w = torch.arange(w, dtype=torch.float32)
7676
grid_d = torch.arange(d, dtype=torch.float32)
7777

78-
grid_h, grid_w, grid_d = torch.meshgrid(grid_h, grid_w, grid_d, indexing="ij")
78+
grid_h, grid_w, grid_d = torch.meshgrid(grid_h, grid_w, grid_d)
7979

8080
if embed_dim % 6 != 0:
8181
raise AssertionError("Embed dimension must be divisible by 6 for 3D sin-cos position embedding")

0 commit comments

Comments
 (0)