Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XSS vulnerability in week 3 #23

Closed
felixschorer opened this issue Jan 13, 2017 · 6 comments
Closed

XSS vulnerability in week 3 #23

felixschorer opened this issue Jan 13, 2017 · 6 comments

Comments

@felixschorer
Copy link
Contributor

Both projects using Google Spreadsheets are vulnerable to Cross Site Scripting (XSS).

@shiffman
Copy link
Collaborator

Any suggestions for best / easiest way to fix this?

@felixschorer
Copy link
Contributor Author

Well, in the case of mad libs you can for example just reject everything with regex which isn't alphanumerical. That would certainly be the easiest and most robust fix.

@felixschorer
Copy link
Contributor Author

felixschorer commented Jan 16, 2017

I've also added some entries to the spreadsheets which exploit that XSS vulnerability. My intent was it to inform inexperienced web developers, who are thinking about using your code. It should be easy to test your fix with those entries.

@felixschorer
Copy link
Contributor Author

felixschorer commented Jan 16, 2017

And also, thank you very much for taking this so seriously.
I would appreciate it if you could do a video on web security such as XSS or SQL injection attacks.

@misterhtmlcss
Copy link

misterhtmlcss commented Jan 16, 2017

@lgfrbcsgo , why not offer to create a video or text tutorial for Daniel. He seems to allow guests and then it's a win win, since he doesn't have to circle the wagons then for little details that distract from the core learning experience he's creating.

Seems like both a reasonable request and also a great way to get some exposure for yourself in the process.

Just an idea.

@felixschorer
Copy link
Contributor Author

@misterhtmlcss I like the idea, but the problem is that I lack the experience in teaching. I am a terrible teacher and most of the time have to explain things multiple times to friends when they ask me some fairly basic stuff.
Also no one would like to listen to a terribly English speaking German for an extended period of time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants