Skip to content

Commit e257da5

Browse files
Miriam-Racheltorvalds
authored andcommitted
wifi: iwlwifi: fix system commands group ordering
The commands should be sorted inside the group definition. Fix the ordering so we won't get following warning: WARN_ON(iwl_cmd_groups_verify_sorted(trans_cfg)) Link: https://lore.kernel.org/regressions/2fa930bb-54dd-4942-a88d-05a47c8e9731@gmail.com/ Link: https://lore.kernel.org/linux-wireless/CAHk-=wix6kqQ5vHZXjOPpZBfM7mMm9bBZxi2Jh7XnaKCqVf94w@mail.gmail.com/ Fixes: b6e3d1b ("wifi: iwlwifi: mvm: implement new firmware API for statistics") Tested-by: Niklāvs Koļesņikovs <pinkflames.linux@gmail.com> Tested-by: Damian Tometzki <damian@riscv-rocks.de> Acked-by: Kalle Valo <kvalo@kernel.org> Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com> Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent b57b17e commit e257da5

File tree

1 file changed

+1
-1
lines changed
  • drivers/net/wireless/intel/iwlwifi/mvm

1 file changed

+1
-1
lines changed

drivers/net/wireless/intel/iwlwifi/mvm/ops.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -550,9 +550,9 @@ static const struct iwl_hcmd_names iwl_mvm_system_names[] = {
550550
HCMD_NAME(RFI_CONFIG_CMD),
551551
HCMD_NAME(RFI_GET_FREQ_TABLE_CMD),
552552
HCMD_NAME(SYSTEM_FEATURES_CONTROL_CMD),
553-
HCMD_NAME(RFI_DEACTIVATE_NOTIF),
554553
HCMD_NAME(SYSTEM_STATISTICS_CMD),
555554
HCMD_NAME(SYSTEM_STATISTICS_END_NOTIF),
555+
HCMD_NAME(RFI_DEACTIVATE_NOTIF),
556556
};
557557

558558
/* Please keep this array *SORTED* by hex value.

0 commit comments

Comments
 (0)