Skip to content

Commit 1813e51

Browse files
shakeelbakpm00
authored andcommitted
memcg: increase MEMCG_CHARGE_BATCH to 64
For several years, MEMCG_CHARGE_BATCH was kept at 32 but with bigger machines and the network intensive workloads requiring througput in Gbps, 32 is too small and makes the memcg charging path a bottleneck. For now, increase it to 64 for easy acceptance to 6.0. We will need to revisit this in future for ever increasing demand of higher performance. Please note that the memcg charge path drain the per-cpu memcg charge stock, so there should not be any oom behavior change. Though it does have impact on rstat flushing and high limit reclaim backoff. To evaluate the impact of this optimization, on a 72 CPUs machine, we ran the following workload in a three level of cgroup hierarchy. $ netserver -6 # 36 instances of netperf with following params $ netperf -6 -H ::1 -l 60 -t TCP_SENDFILE -- -m 10K Results (average throughput of netperf): Without (6.0-rc1) 10482.7 Mbps With patch 17064.7 Mbps (62.7% improvement) With the patch, the throughput improved by 62.7%. Link: https://lkml.kernel.org/r/20220825000506.239406-4-shakeelb@google.com Signed-off-by: Shakeel Butt <shakeelb@google.com> Reported-by: kernel test robot <oliver.sang@intel.com> Acked-by: Soheil Hassas Yeganeh <soheil@google.com> Reviewed-by: Feng Tang <feng.tang@intel.com> Acked-by: Roman Gushchin <roman.gushchin@linux.dev> Acked-by: Muchun Song <songmuchun@bytedance.com> Acked-by: Michal Hocko <mhocko@suse.com> Cc: Eric Dumazet <edumazet@google.com> Cc: Johannes Weiner <hannes@cmpxchg.org> Cc: "Michal Koutný" <mkoutny@suse.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
1 parent 408587b commit 1813e51

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

include/linux/memcontrol.h

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -354,10 +354,11 @@ struct mem_cgroup {
354354
};
355355

356356
/*
357-
* size of first charge trial. "32" comes from vmscan.c's magic value.
358-
* TODO: maybe necessary to use big numbers in big irons.
357+
* size of first charge trial.
358+
* TODO: maybe necessary to use big numbers in big irons or dynamic based of the
359+
* workload.
359360
*/
360-
#define MEMCG_CHARGE_BATCH 32U
361+
#define MEMCG_CHARGE_BATCH 64U
361362

362363
extern struct mem_cgroup *root_mem_cgroup;
363364

0 commit comments

Comments
 (0)