Does not compile with VS2017

[csware]

Notepad2e does not compile with VS2017.

There are lots of compile errors and also the project file has hard-coded values which point to old WIndows SDKs.

[ProgerXP]

@cshnik Look into this issue please.

[cshnik]

Fixed.

1. Removed specific target SDK (default is OK).
2. Target platform toolset upgraded to "Visual Studio 2017 - Windows XP (v141_xp)".
   Switching this option back to "Visual Studio 2015 - Windows XP (v140_xp)" (Notepad2e> Properties> General> Platform Toolset) allow user to rebuild the project in VS2015.

[csware]

This change is not sufficient - VS still complains about missing precompiled header includes... I have a working version, I'll open a MR soon.

[csware]

How do you build Notepad2e? Using teh VS2017 IDe or using the wdkbuild batch file?

[ProgerXP]

This change is not sufficient - VS still complains about missing precompiled header includes... I have a working version, I'll open a MR soon.

I confirm this. Neither Release nor Debug configurations compile on VS2017:

src\extension\base64.c(334, 0): error C1010: unexpected end of file while looking for precompiled header. Did you forget to add '#include "stdafx.h"' to your source?
src\extension\commonutils.c(30, 0): error C1010: unexpected end of file while looking for precompiled header. Did you forget to add '#include "stdafx.h"' to your source?
src\extension\externals.c(109, 0): error C1010: unexpected end of file while looking for precompiled header. Did you forget to add '#include "stdafx.h"' to your source?
src\extension\stringrecoding.c(741, 0): error C1010: unexpected end of file while looking for precompiled header. Did you forget to add '#include "stdafx.h"' to your source?
src\extension\strtobase64.c(47, 0): error C1010: unexpected end of file while looking for precompiled header. Did you forget to add '#include "stdafx.h"' to your source?
src\extension\strtohex.c(122, 0): error C1010: unexpected end of file while looking for precompiled header. Did you forget to add '#include "stdafx.h"' to your source?
src\extension\strtoqp.c(197, 0): error C1010: unexpected end of file while looking for precompiled header. Did you forget to add '#include "stdafx.h"' to your source?
src\extension\tinyexpr\tinyexpr.c(961, 0): error C1010: unexpected end of file while looking for precompiled header. Did you forget to add '#include "stdafx.h"' to your source?
src\extension\trace.c(99, 0): error C1010: unexpected end of file while looking for precompiled header. Did you forget to add '#include "stdafx.h"' to your source?

@cshnik Ensure that the project can be built on a clean system with VS2017 or VS2015 from ground up with no errors (possibly requiring some simple switch of the target SDK only).

[csware]

I have a working version, I'll open a MR soon.

[csware]

How do you build Notepad2e? Do you use Notepad2.mak (I doubt as this is missing the SCI_OWNREGEX definition), but the VS solution file has other options set (especially some security features are not set; also it optimizes for speed but Notepad2.mak or size;; the project uses the runtime MultiThreaded, but the mak file MultiThreadedDLL)...

[cshnik]

I was able to reproduce the issue. The point is: there are multiple problems with x64 configurations (since we never tested/used it) and x64 is selected by default on project startup.
At this point, please use x86 configurations to build the project.