Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement search query quote parsing #88

Open
malberts opened this issue Jan 10, 2025 · 2 comments
Open

Implement search query quote parsing #88

malberts opened this issue Jan 10, 2025 · 2 comments

Comments

@malberts
Copy link
Contributor

malberts commented Jan 10, 2025

Follow-up to #31

Quote parsing is not implemented yet.

The skipped test added in #70 expected quotes around each individual OR value, to allow for multiple quoted values:
haswbfacet:P42="foo bar"|second|"third value"

However, the quote parsing that returns $quotedValue in HasWbFacetFeature::doApply() (via SimpleKeywordFeature) seems to expect quotes for the entire keyword value:
haswbfacet:"P42=foo bar|second|third value"

@malberts
Copy link
Contributor Author

malberts commented Jan 10, 2025

If we make HasWbFacetFeature handle quotes as per the example test case, then our keyword will behave slightly differently compared to haswbstatement. However, that might not be an issue, since our OR handling is already different (P42=foo|bar|baz vs P42=foo|P42=bar|P42=baz).

@JeroenDeDauw
Copy link
Member

I do not have a product-level preference for the quotation form, both seem viable enough, and we generate the search string via the UI anyway, so it's not central to the UX. So whatever is easier to implement, or up to the implementer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants