Upgrade to Laravel 7.x #4482

nolanpro · 2022-08-23T21:47:26Z

Issues
https://processmaker.atlassian.net/browse/FOUR-6564
https://processmaker.atlassian.net/browse/FOUR-6565

Upgrade to Laravel 7

Package PRs

Note: PMQL was locked to version <=6 so I temporarily specified dev-develop until there's a new release. I would recommend doing a release then updating this composer.json, then running composer update and committing composer.lock, before merging this PR.

Testing:

Install all packages and use the feature/FOUR-6565 branch for the above packages.
Skim the code changes and identify areas that may be affected
Try out a bunch of different features of the app

Original Laravel Shift PR text below

This pull request includes the changes for upgrading to Laravel 7.x. Feel free to commit any additional changes to the shift-69390 branch.

Before merging, you need to:

Checkout the shift-69390 branch
Review all pull request comments for additional changes
Run composer update (if the scripts fail, add --no-scripts)
Clear any config, route, or view cache
Thoroughly test your application (no tests?, no CI?)

If you need help with your upgrade, check out the Human Shifts. You may also join the Shifty Coders Slack workspace to level-up your Laravel skills.

Since PHP 5.4 the short array syntax `[]` may be used instead of `array()`.

In an effort to make upgrading the constantly changing config files easier, Shift defaulted them and merged your true customizations - where ENV variables may not be used.

nolanpro · 2022-08-23T21:47:26Z

⚠️ Shift detected a custom namespace. Laravel now recommends keeping the default App namespace. While it was available to customize in previous versions using app:name, this command was removed in Laravel 6.0.

Shift recommends changing this to align with Laravel and improve its automation. After doing so, you are welcome to request a rerun of this Shift.

nolanpro · 2022-08-23T21:47:27Z

❌ Shift was unable to find your Exception Handler. Laravel 7 upgraded to Symfony 5 which passes instances of the Throwable interface instead of Exception.

You should compare your app/Exceptions/Handler.php with the default Laravel 7 version to finalize any changes.

nolanpro · 2022-08-23T21:47:28Z

ℹ️ Laravel 7 moved the Authentication components into a separate laravel/ui package, which includes the make commands as well as the traits related to authentication.

Shift added this dependency for convenience. However, if you do not plan to use the Authentication components, you may remove this dependency as well as the Auth controllers from your application.

nolanpro · 2022-08-23T21:47:28Z

⚠️ Laravel 7 removed "factory types". While available, this was undocumented since Laravel 5.2. Since then the preferred method has been factory states.

Shift converted usages of $factory->defineAs() to $factory->state(). However, you should review this commit and run your tests to see if any additional changes to your factory states are necessary.

nolanpro · 2022-08-23T21:47:29Z

⚠️ The MAIL_DRIVER environment variable was renamed in Laravel 7 to MAIL_MAILER in order to support multiple mail configurations.

Shift attempted to automate this change, but you should review any additional environment configuration and update to the new variable name.

nolanpro · 2022-08-23T21:47:29Z

⚠️ Shift upgraded your configuration files by defaulting them and merging your true customizations. These include values which are not changeable through core ENV variables.

You should review this commit for additional customizations or opportunities to use new ENV variables. If you have a lot of customizations, you may undo this commit with git revert 76726389 and make the config file changes manually.

nolanpro · 2022-08-23T21:47:30Z

ℹ️ Shift updated your dependencies for Laravel 7. While many of the popular packages are reviewed, you may have to update additional packages in order for your application to be compatible with Laravel 7.

Watch dealing with dependencies for tips on handling any additional package incompatibilities.

nolanpro · 2022-08-23T21:47:31Z

ℹ️ Laravel 7 removed some of the PHPUnit configuration in favor of the defaults. While this is not a required changed, it is a good opportunity to compare your phpunit.xml with the default Laravel 7 version to modernize your configuration.

nolanpro · 2022-08-23T21:47:31Z

nolanpro · 2022-08-23T21:47:32Z

⚠️ Shift found potential uses of the different validation rule. In Laravel 7, this rule will fail if one of the specified parameters is missing from the request. As this was likely the expected behavior, it should not affect your validation. Nonetheless you should be aware of this change.

nolanpro · 2022-08-23T21:47:32Z

⚠️ Laravel 7 uses a new date format when serializing models. The previous format was 2019-12-02 20:01:00. Now, dates are serialized using an ISO-8601 compatible date format of 2019-12-02T20:01:00.283041Z in UTC.

This does not affect how dates are stored. Only how they are serialized when using the toArray or toJson Eloquent methods.

If you need to preserve the previous format, you may override the serializeDate method on your model. Review the Date Serialization section of the Upgrade Guide for more details.

nolanpro · 2022-08-23T21:47:33Z

ℹ️ All of the underlying Symfony components used by Laravel have been upgraded to Symfony 5. If you are directly interacting with any Symfony component, you should review the Symfony change log for additional changes.

nolanpro · 2022-08-23T21:47:34Z

⚠️ Shift detected you are using a Laravel package like Horizon or Nova which may need to have its published assets regenerated after upgrading. Be sure to use artisan to republish these assets as well as php artisan view:clear to avoid any errors.

nolanpro · 2022-08-23T21:47:34Z

⚠️ Laravel 7.x has reached end of life. It no longer receives bug fixes or security updates. Shift recommends continuing to upgrade to the latest version (Laravel 9.x).

For tips on running multiple Shifts effectively, watch upgrading old Laravel applications.

config/datasources.php

config/savedsearch.php

composer.json

nolanpro · 2022-08-26T19:38:31Z

@caleeli Made those changes, thanks!

caleeli · 2022-08-30T19:04:54Z

@nolanpro please include Package-versions PR to description https://github.com/ProcessMaker/package-versions/pull/54

nolanpro · 2022-10-14T17:16:42Z

Closing in favor of #4483

laravel-shift added 9 commits August 23, 2022 21:46

Apply code style

2c5d963

Adopt short array syntax

1c3290a

Since PHP 5.4 the short array syntax `[]` may be used instead of `array()`.

Add laravel/ui dependency

3386bed

Convert factory types to states

349fa5d

Shift config files

532d694

Default config files

7672638

In an effort to make upgrading the constantly changing config files easier, Shift defaulted them and merged your true customizations - where ENV variables may not be used.

Bump Laravel dependencies

2772efa

Shift cleanup

ff2b75a

Shift test config and references

f2c1f28

nolanpro added 7 commits August 23, 2022 14:55

Update error handler to use Throwable

efd5ac2

Remove unused traits in controllers

c747ac0

Update namespaces for medialibrary

0f6256e

Use guzzle 7.4

47d568b

Remove unused package

07713ca

Update argument compatibility

973516f

Update additional MediaLibrary namespaces

2d25ec0

nolanpro added 15 commits August 23, 2022 14:55

Fix Laravel echo server error

cb15244

Upgrade Spatie MediaLibrary to v9

6c84a28

Remove script

f6cb45a

Remove .phpunit.result.cache

f8689bf

Add .phpunit.result.cache to git ignore

7308ed3

Change getOriginal to getRawOriginal in test

da50ad1

Fix custom MediaPathGenerator

f8d25ea

Upgrade php swagger

e7f7c98

Add bearer auth to swagger ui

dc78e37

Fix phpunit tests

1bd9ab6

Fix additional tests

492d58e

Add helper function to register OpenAPI annotations

cb7cd53

Use original mail settings for now

7b0b6e2

Set pmql to dev-develop until a new release is available

8b8b3f0

Run composer update

7e0626d

nolanpro changed the title ~~Laravel 7.x Shift~~ Upgrade to Laravel 7.x Aug 23, 2022

caleeli self-requested a review August 24, 2022 19:59

caleeli reviewed Aug 26, 2022

View reviewed changes

config/datasources.php Outdated Show resolved Hide resolved

config/savedsearch.php Outdated Show resolved Hide resolved

composer.json Show resolved Hide resolved

nolanpro added 2 commits August 26, 2022 12:35

Remove config files from packages

ae645ab

Update horizon assets

e07b67c

caleeli self-requested a review August 30, 2022 19:05

caleeli approved these changes Aug 30, 2022

View reviewed changes

Merge branch 'develop' into shift-69390

5b033bf

nolanpro closed this Oct 14, 2022

Upgrade to Laravel 7.x #4482

Upgrade to Laravel 7.x #4482

Uh oh!

Conversation

nolanpro commented Aug 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nolanpro commented Aug 23, 2022

Uh oh!

nolanpro commented Aug 23, 2022

Uh oh!

nolanpro commented Aug 23, 2022

Uh oh!

nolanpro commented Aug 23, 2022

Uh oh!

nolanpro commented Aug 23, 2022

Uh oh!

nolanpro commented Aug 23, 2022

Uh oh!

nolanpro commented Aug 23, 2022

Uh oh!

nolanpro commented Aug 23, 2022

Uh oh!

nolanpro commented Aug 23, 2022

Uh oh!

nolanpro commented Aug 23, 2022

Uh oh!

nolanpro commented Aug 23, 2022

Uh oh!

nolanpro commented Aug 23, 2022

Uh oh!

nolanpro commented Aug 23, 2022

Uh oh!

nolanpro commented Aug 23, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nolanpro commented Aug 26, 2022

Uh oh!

caleeli commented Aug 30, 2022

Uh oh!

nolanpro commented Oct 14, 2022

Uh oh!

Uh oh!

nolanpro commented Aug 23, 2022 •

edited

Loading