PR observation

Author: pmPaulis

ProcessMaker/Http/Controllers/Api/ProcessController.php

@@ -110,7 +110,7 @@ public function index(Request $request)
         // Filter by category
         $category = $request->input('category', null);
         if (!empty($category)) {
-            $processes->category($category);
+            $processes->processCategory($category);
         }
 
         if (!empty($pmql)) {

ProcessMaker/Models/Process.php

@@ -453,7 +453,7 @@ public function scopeArchived($query)
     /**
      * Scope a query to include a specific category
      */
-    public function scopeCategory($query, int $id)
+    public function scopeProcessCategory($query, int $id)
     {
         return $query->where('processes.process_category_id', $id);
     }

tests/Feature/Api/ProcessTest.php

@@ -570,10 +570,10 @@ public function testFilterCategory()
         // Get process without category
         $response = $this->apiCall('GET', route('api.processes.index', ['per_page' => 5, 'page' => 1]));
         $response->assertJsonCount(5, 'data');
-        // Get process without category
+        // Get process related categoryA
         $response = $this->apiCall('GET', route('api.processes.index', ['category' => $categoryA->id]));
         $response->assertJsonCount(0, 'data');
-        // The first page should have 5 items related to the category
+        // Get process related categoryB
         $response = $this->apiCall('GET', route('api.processes.index', ['category' => $categoryB->id]));
         $response->assertJsonCount(5, 'data');
     }