Merge pull request #6215 from ProcessMaker/fix-failing-script-executor-test

ryancooley · web-flow · commit 263190be6f04 · 2024-02-14T09:00:55.000-08:00
Fix failing 'ScriptExecutorsTest'
diff --git a/tests/Feature/ImportExport/Exporters/ScriptExporterTest.php b/tests/Feature/ImportExport/Exporters/ScriptExporterTest.php
@@ -114,6 +114,7 @@ public function testHiddenUsesParentMode()
 
     public function testNoMatchingRunAsUser()
     {
+        $admin_user = User::factory()->create(['is_administrator' => true]);
         DB::beginTransaction();
         $user = User::factory()->create(['username' => 'test']);
         $script = Script::factory()->create(['title' => 'test', 'run_as_user_id' => $user->id]);
@@ -124,7 +125,8 @@ public function testNoMatchingRunAsUser()
         $this->import($payload);
 
         $script = Script::where('title', 'test')->firstOrFail();
-        $this->assertNull($script->run_as_user_id);
+        $this->assertEquals($script->run_as_user_id, $admin_user->id);
+        $admin_user->delete();
     }
 
     public function testRunAsUserIdNull()

Original file line number	Diff line number	Diff line change
`@@ -114,6 +114,7 @@ public function testHiddenUsesParentMode()`
`114`	`114`
`115`	`115`	`public function testNoMatchingRunAsUser()`
`116`	`116`	`{`
	`117`	`+ $admin_user = User::factory()->create(['is_administrator' => true]);`
`117`	`118`	`DB::beginTransaction();`
`118`	`119`	`$user = User::factory()->create(['username' => 'test']);`
`119`	`120`	`$script = Script::factory()->create(['title' => 'test', 'run_as_user_id' => $user->id]);`
`@@ -124,7 +125,8 @@ public function testNoMatchingRunAsUser()`
`124`	`125`	`$this->import($payload);`
`125`	`126`
`126`	`127`	`$script = Script::where('title', 'test')->firstOrFail();`
`127`		`- $this->assertNull($script->run_as_user_id);`
	`128`	`+ $this->assertEquals($script->run_as_user_id, $admin_user->id);`
	`129`	`+ $admin_user->delete();`
`128`	`130`	`}`
`129`	`131`
`130`	`132`	`public function testRunAsUserIdNull()`