Added sneaking option to controll states #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Meldiron
commented
Nov 4, 2017
Meldiron
commented
- added option 'sneak' to setControllState,
- changed api documentation, added this option there
plexigras
reviewed
Nov 4, 2017
lib/plugins/physics.js
Outdated
| @@ -34,7 +34,8 @@ function inject (bot) { | |||
| left: false, | |||
| right: false, | |||
| jump: false, | |||
| sprint: false | |||
| sprint: false, | |||
| sneak: false, | |||
There was a problem hiding this comment.
eslint doesn't like the trailing commas, you will need to remove it to confirm to the code style rules
rom1504
reviewed
Nov 5, 2017
| } else if (control === 'sneak') { | ||
| bot._client.write('entity_action', { | ||
| entityId: bot.entity.id, | ||
| actionId: state ? 0 : 1, |
|
Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.