Add direction support to activateBlock, openBlock #2039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
failing tests |
Jeah and this would break anything still using callbacks. So I think I will put this on hold until callbacks are gone. |
|
blocked by #1482 |
|
Can you rebase this on master @IceTank ? |
IceTank
force-pushed
the
openBlock-direction-support
branch
from
7147947
to
c05689e
Compare
rom1504
reviewed
Feb 13, 2022
| @@ -338,8 +338,8 @@ function inject (bot, { version, hideErrors }) { | |||
| } | |||
| } | |||
|
|
|||
| async function openBlock (block) { | |||
| bot.activateBlock(block) | |||
| async function openBlock (block, direction, cursorPos) { | |||
There was a problem hiding this comment.
looks like you forgot the default here
There was a problem hiding this comment.
Yeah I just noticed that there are also types missing
|
|
|
Resolve conflicts please |
IceTank
force-pushed
the
openBlock-direction-support
branch
from
32e49e3
to
e87992e
Compare
IceTank
force-pushed
the
openBlock-direction-support
branch
from
e87992e
to
20bc786
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why? Because you cannot open containers if they are at y level 255 because you cannot activate blocks from the top at y level 255. So openContainer does not work at y 255.