Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent NavigationPage & TabbedPage from inheriting parents BindingContext #2590

Merged
merged 1 commit into from
Oct 15, 2021
Merged

Prevent NavigationPage & TabbedPage from inheriting parents BindingContext #2590

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/Forms/Prism.Forms/Common/PageUtilities.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,6 +305,15 @@ public static void SetAutowireViewModel(VisualElement element)
//and we don't want that. Set the VML
ViewModelLocator.SetAutowireViewModel(element, true);
}

//due to the nature of NavigationPage and TabbedPage, it's possibe for them to inherit their parent BindingContext
//this causes issues with navigation interfaces being called when they shouldn't be. In this scenario, we want
//to set the binding context of these types to prevent them from inheriting their parent's binding context
var type = element.GetType();
if ((type == typeof(NavigationPage) || type == typeof(TabbedPage)) && element.BindingContext == null)
{
element.BindingContext = element;
}
}
}
}