Prevent NavigationPage & TabbedPage from inheriting parents BindingContext #2590
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
By default, elements in a XF app will always inheit their parent's BindingContext. This becomes an issue when using a FlyoutPage and a TabbedPage and then using a NavigationPage as a child. The NavigationPage will inherit the parents BindingContext which would then invoke the Prism navigation interfaces when they shouldn't be invoked.
We fix this by preventing the NavigationPage and TabbedPage from inheriting their parent's BindingContext.
Bugs Fixed
API Changes
None
Behavioral Changes
The NavigationPage and TabbedPage types will no longer inherit their Parent's BindingContext. If you would like for these types to have a iffeent BindingContext, you will have to register a ViewModel with the Prism NavigatinService.
PR Checklist