Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ReDoS #3078

Merged
merged 3 commits into from
Sep 15, 2021
Merged

Fix ReDoS #3078

merged 3 commits into from
Sep 15, 2021

Conversation

ready-research
Copy link
Contributor

Fix ReDoS

@ready-research
[Security] Fix ReDoS (#1)
b5cce83 
* [Security] Fix ReDoS

Fix ReDoS
@github-actions
Copy link

github-actions bot commented Sep 14, 2021 •
edited
Loading

JS File Size Changes (gzipped)

A total of 1 files have changed, with a combined diff of +5 B (+0.5%).

file master pull size diff % diff
components/prism-markup.min.js 1.03 KB 1.04 KB +5 B +0.5%

Generated by 🚫 dangerJS against 243390e

@RunDevelopment
Copy link
Member

components/prism-markup.min.js has a new line at the end for some reason. That's why the build fails.

@ready-research
Copy link
Contributor Author

ready-research commented Sep 14, 2021 •
edited
Loading

@RunDevelopment Is it okay now?
Please validate the huntr link by clicking on mark as valid, and also you can confirm the fix. Thank you.

@RunDevelopment
Copy link
Member

@ready-research That new line is still present. Your last commit was empty.

@ready-research
Copy link
Contributor Author

@RunDevelopment I am not seeing any new line in components/prism-markup.min.js. Can you please edit that if you have permission to do that? Or feel free to raise a new pull to resolve this issue. Thank you.

@RunDevelopment RunDevelopment merged commit 0ff371b into PrismJS:master Sep 15, 2021
@ready-research
Copy link
Contributor Author

@RunDevelopment Can you please confirm the fix in huntr?

@RunDevelopment
Copy link
Member

Done :)

@RunDevelopment RunDevelopment mentioned this pull request Sep 16, 2021
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Sep 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement language-definitions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ready-research @RunDevelopment