Added support for ASP.NET Razor #3064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JS File Size Changes (gzipped)A total of 3 files have changed, with a combined diff of +1.02 KB (+21.8%).
|
|
Also, since MS seems to let VBHTML die, I will not add support for it. I was unable to find sufficient documentation for the language variant. MS has exactly one page of documentation for VBHTML last updated 7 years ago. However, from that page, I can see that VBHTML is even more context-sensitive than CSHTML and will most likely require an even more complex grammar. I do not wish to put time and effort into creating and maintaining the grammar of a poorly-documented, dying, incredibly complex language. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #1225.
Man, this was difficult. CSHTML is incredibly context-sensitive, so I had to write something pretty close to a parser. I think it turned out ok in the end but the whole language definition is still pretty complex.