Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve support for Dart classes & generics #2810

Merged
merged 1 commit into from
Mar 17, 2021
Merged

Improve support for Dart classes & generics #2810

merged 1 commit into from
Mar 17, 2021

Conversation

brianegan
Copy link
Contributor

  • No longer depend on keywords such as new or extends
  • Detect PascalCase class names instead
  • Support generic parameters as well
  • Properly highlights class constructors
  • Added tests
Before After
Screenshot from 2021-03-17 14-37-42 Screenshot from 2021-03-17 14-39-15
Screenshot from 2021-03-17 14-38-05 Screenshot from 2021-03-17 14-39-06

@github-actions
Copy link

github-actions bot commented Mar 17, 2021 •
edited
Loading

JS File Size Changes (gzipped)

A total of 1 files have changed, with a combined diff of +228 B (+46.3%).

file master pull size diff % diff
components/prism-dart.min.js 492 B 720 B +228 B +46.3%

Generated by 🚫 dangerJS against 7b42bc5

RunDevelopment
RunDevelopment requested changes Mar 17, 2021
View reviewed changes
Copy link
Member

@RunDevelopment RunDevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @brianegan!

One small nit and then gtg.

components/prism-dart.js Show resolved Hide resolved
@RunDevelopment RunDevelopment merged commit d0bcd07 into PrismJS:master Mar 17, 2021
@RunDevelopment
Copy link
Member

Thank you for contributing @brianegan!

@brianegan
Copy link
Contributor Author

brianegan commented Mar 17, 2021 via email

@brianegan brianegan deleted the dart-classes branch March 18, 2021 11:31
@sync-by-unito sync-by-unito bot mentioned this pull request Jun 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RunDevelopment RunDevelopment RunDevelopment approved these changes

Assignees
No one assigned
Labels
enhancement language-definitions needs changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brianegan @RunDevelopment