Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IconMapViewController in example project #103

Open
GabLeRoux opened this issue Aug 21, 2017 · 0 comments
Open

Fix IconMapViewController in example project #103

GabLeRoux opened this issue Aug 21, 2017 · 0 comments

Comments

@GabLeRoux
Copy link

GabLeRoux commented Aug 21, 2017

I gave example project a try and it works well, but there's a problem with the last page which exposes all icons:

image

None icons are being displayed from that last tab, tried all icon sets.

Clicking an icons logs this:

===================Code Autogeneration ===================

FAKFontAwesome *Icon = [FAKFontAwesome IconWithSize:30];
[Icon addAttribute:NSForegroundColorAttributeName value:[UIColor whiteColor]];
UIImage *IconImage = [Icon imageWithSize:CGSizeMake(30, 30)];

==========================================================

I'd say this code generator is broken, it shouldn't be using the computed characters, but the character's name instead.

Problem would be somewhere in FontAwesomeKitExample/FontAwesomeKitExample/IconMapViewController.m

I suppose this used to work in previous versions of xcode. It's not a big problem, but I'm sure this would deserve a fix as it may prevent new people from using this library as it seems broken, but everything else works fine.

I see that a swift rewrite was planed for the code generator in #92

@GabLeRoux GabLeRoux changed the title Fix example project for whole list Fix IconMapViewController in example project Aug 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant