Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore Jupyter notebooks in .gitignore #3073

Merged
merged 2 commits into from
Aug 2, 2020
Merged

ignore Jupyter notebooks in .gitignore #3073

merged 2 commits into from
Aug 2, 2020

Conversation

jameslamb
Copy link

  • adds new tests (if appropriate)
  • add a changelog entry in the changes/ directory (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

What does this PR change?

This PR adds the following things to .gitignore:

  • Jupyter notebooks (.ipynb)
  • objects from compiling C/C++ code (.a, .dll, .dylib, .o)
  • Windows executables (.exe, .msi)

Why is this PR important?

While working on #3000 , I was developing in a Jupyter notebook. I found that .ipynb notebooks are not currently ignored in this repo. I think that they should be, since this repo currently does not have any notebooks in it.

The C/C++ stuff and Windows executables are other things I noticed missing and that I expect should not be checked into this project.

Thanks for your time and consideration.

@codecov
Copy link

codecov bot commented Aug 2, 2020

Codecov Report

Merging #3073 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jameslamb !

@cicdw cicdw merged commit 98a7999 into PrefectHQ:master Aug 2, 2020
@jameslamb jameslamb deleted the fix/ignore-notebooks branch September 15, 2020 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants