-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check concurrency limit before submitting tasks to TaskRunner #8539
Comments
Unfortunately this is a bit difficult as scaling to large numbers of tasks requires that orchestration of the tasks occur in a distributed manner. |
@j-tr would a client-side setting that controls the number of concurrently submitting task runs suffice for you? |
@madkinsz I'm afraid that a purely client-side approach would probably not help very much. we already considered application-level workarounds that only submit a certain number of tasks at a time, but since our main objective is to protect a database and we have no control over the number of concurrently running flows, we need some sort of global limit. |
This issue is stale because it has been open 30 days with no activity. To keep this issue open remove stale label or comment. |
Hi @billpalombi, is this capability something that is on the current roadmap? |
First check
Prefect Version
2.x
Describe the current behavior
Concurrency limits are checked after the task is submitted to the TasksRunner. For distributed task runners like Ray, this causes upscaling based on the total number of submitted tasks and not on the number of runnable tasks according to the concurrency limits. Especially for flows with a large number of tasks but rather low concurrency limits, this causes massive overprovisioning of compute resources.
Describe the proposed behavior
Only submit tasks to the task runner when free concurrency slots are available, which would lead to upscaling based on the concurrency limits and not the total number of tasks.
Example Use
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: