Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Junk" in the output signal when non-ascii input signal is provided #2

Open
Maharshi-Pandya opened this issue Oct 29, 2020 · 1 comment

Comments

@Maharshi-Pandya
Copy link

  • When non-ascii characters i.e. unicode characters or emojis, are provided as an input, the output signal gives out junk characters instead, for some reason.

Example highlighting the issue...(Tested in default settings)

InputIssue

Here's the output signal...

OutputIssue

@yashrajkakkad
Copy link
Collaborator

Hi @Maharshi-Pandya, as our objective was only to demonstrate digital communication techniques, we only had the ASCII character set in our mind. However, feel free to modify the code to support Unicode (I am sure its not very hard) and send a Pull request. We'll gladly review and approve if seems good. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants