Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update #3

Merged
merged 4 commits into from
May 23, 2019
Merged

Update #3

merged 4 commits into from
May 23, 2019

Conversation

PranovD
Copy link
Owner

@PranovD PranovD commented May 23, 2019

We are excited to review your PR.

So we can do the best job, please check:

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.

sfilipi and others added 4 commits May 20, 2019 15:42
@sfilipi
Sample of using LoadFromEnumerable with a SchemaDefinition (#3696)
706299b 
* Sample of using LoadFromEnumerable with a SchemaDefinition
@najeeb-kazmi
Adding samples for data save and load from text and binary files (#3745)
ce46faa 
* Adding samples for data save and load from text and binary files

* PR comments

* nits
@zeahmed
Upgraded the TensorFlow version from 1.12.0 to 1.13.1 (#3758)
2ee4d31
@codemzs
Access indices array for VBuffer in KeyToVector transformer only when…
51b10fc 
… resulting vector is sparse. (#3763)

* Create indicies array for sparse vector in KeyToValue transfomer only when resulting vector is sparse.

* PR feedback.

* cleanup.

* cleanup.

* port changes from PR #2678.
@PranovD PranovD merged commit 2276fea into PranovD:master May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@PranovD @Oceania2018 @sfilipi @najeeb-kazmi @zeahmed @codemzs