Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timepicker is too large for smaller devices #81

Closed
damiancioo opened this issue Jun 9, 2021 · 4 comments
Closed

Timepicker is too large for smaller devices #81

damiancioo opened this issue Jun 9, 2021 · 4 comments

Comments

@damiancioo
Copy link

When using timepicker, for example

MaterialDialog = MaterialDialog().also {
    it.build {
        timepicker(
            title = "Select time",
            initialTime = LocalTime.now(),
            onTimeChange = {}
        )

        buttons {
            positiveButton(
                res = android.R.string.ok
            )
            negativeButton(
                res = R.string.cancel_button_title
            )
        }
    }
}

On smaller devices (for example Nexus S 480x800), whole dialog is a little too big, so buttons are not rendering to user.

There might be added configuration for adjusting timepicker elements size.

device-2021-06-09-131505

@nglauber
Copy link

nglauber commented Jun 11, 2021

[Almost] the same applies to Date dialog... Buttons are not visible...

@PranavMaganti
Copy link
Owner

Thanks for letting me know about this. This is likely due to the updated the top and bottom padding on the dialog to better follow the material design spec. I'll take a look at how I can scale the rest of the dialog contents to account for the smaller screen size.

@damiancioo
Copy link
Author

it's exactly how it was on 480x800 phones :/

@PranavMaganti
Copy link
Owner

Should be fixed in 0.5.0 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants