Skip to content

Bump to Node 22.15.1 and removes node-fetch #5214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

JustinGrote
Copy link
Collaborator

Fixes #5213

PR Summary

Bumps to Node 22.15.1 and removes node-fetch. Requires VSCode v1.101 or higher for future extension releases.

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • PR has tests
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

@Copilot Copilot AI review requested due to automatic review settings June 12, 2025 21:02
@JustinGrote JustinGrote self-assigned this Jun 12, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the extension’s supported VS Code version, bumps Node and TypeScript type dependencies, and removes the now-unnecessary node-fetch package.

  • Raise engines.vscode to ^1.101.0
  • Drop node-fetch and its type definitions in favor of Node’s built-in fetch
  • Bump @types/node to match Node v22.15.1 and update @types/vscode
Comments suppressed due to low confidence (2)

package.json:9

  • Consider adding an engines.node field (e.g., "node": ">=22.15.1") to package.json to enforce the minimum Node.js runtime version required by this extension.
"vscode": "^1.101.0"

package.json:63

  • Since node-fetch has been removed in favor of the native fetch API in Node.js, consider updating the README or CHANGELOG to document this change and any migration steps for consumers.
"node-fetch": "^2.7.0"

@JustinGrote
Copy link
Collaborator Author

@andyleejordan eslint got real mad at me for unchanged stuff, do we want to fix these or add a rules exclusion?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump to Node 22.15.1
1 participant