Enable ability to trace DAP messages at client side #5064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustinGrote
force-pushed
the
justingrote/feature/dap-trace
branch
from
782cea2 to
3b3c4d5
Compare
JustinGrote
added
Issue-Enhancement
JustinGrote
force-pushed
the
justingrote/feature/dap-trace
branch
from
a1de55f to
6669264
Compare
JustinGrote
force-pushed
the
justingrote/feature/dap-trace
branch
from
7d355cb to
d7ad116
Compare
andyleejordan
approved these changes
Oct 17, 2024
|
@andyleejordan thank you! I left this at two commits and didn't rebase so as not to require re-review, should still be a linear history commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR adds a setting to enable tracing of DAP requests via the output pane to simplify issue troubleshooting and enable better user reporting.
By enabling the
powershell.trace.dapoption, a new DAP output pane will appear upon debug invocation. When set to "debug" log level, it will show summary of messages back and forth, similar to LSP "messages" setting. When set to "trace" log level, it will also show content similar to LSP "verbose" setting. The panel will not disappear once debug stops and will be resused for subsequent DAP connections.This PR also segregates the LSP messages into their own output pane so they don't cross-pollute with PSES messages.
Capture.mp4
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets.Please mark anything not applicable to this PR
NA.WIP:to the beginning of the title and remove the prefix when the PR is ready